Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yaml to v3 #2339

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Update yaml to v3 #2339

merged 3 commits into from
Aug 25, 2022

Conversation

CoreFloDev
Copy link
Contributor

Hi,

I have updated to Yaml v3 as I already have dependencies using it on my project and I don't see the advantage of using both at the same time.

I have made the change based on this:
https://github.com/grafana/mimir/pull/2468/files#diff-b6523cb0f118ebcaa2aa648d3810f1ac33a06a9e4ae19b11f0205c90014d879e

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Aug 25, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 75.463% when pulling c00ea6d on CoreFloDev:feat/update-to-yaml-v3 into 7949117 on 99designs:master.

@CoreFloDev
Copy link
Contributor Author

Hi,

I don't see how to execute that test :

--- FAIL: TestSubscriptions (2.02s)
    --- FAIL: TestSubscriptions/websocket_gets_errors (2.01s)
        subscription_test.go:192: 
            	Error Trace:	subscription_test.go:192
            	Error:      	Not equal: 
            	            	expected: 8
            	            	actual  : 3
            	Test:       	TestSubscriptions/websocket_gets_errors

I can't find it on codegen/testserver, is there something specific to do to get it?

@StevenACoffman StevenACoffman merged commit 32e2ccd into 99designs:master Aug 25, 2022
@StevenACoffman
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CoreFloDev @coveralls @StevenACoffman